[fix][client] Replace String with WebTarget in authenticationStage #23924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]>
lhotari
requested changes
Feb 17, 2025
Member
lhotari
left a comment
lhotari
left a comment
There was a problem hiding this comment.
This is a breaking change in the org.apache.pulsar.client.api.Authentication API that is exposed for plugins to implement.
There should be a PIP in place and the implementation should be made in a backwards compatible way.
It should be possible to add conditional logic when the Authentication instance implements some other interface which is for handling this particular case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is based on #23905 and is used to fix the TLS context loss.
Modifications
org.apache.pulsar.client.api.Authentication#authenticationStage(javax.ws.rs.client.WebTarget, org.apache.pulsar.client.api.AuthenticationDataProvider, java.util.Map<java.lang.String,java.lang.String>, java.util.concurrent.CompletableFuture<java.util.Map<java.lang.String,java.lang.String>>)instead oforg.apache.pulsar.client.api.Authentication#authenticationStage(java.lang.String, org.apache.pulsar.client.api.AuthenticationDataProvider, java.util.Map<java.lang.String,java.lang.String>, java.util.concurrent.CompletableFuture<java.util.Map<java.lang.String,java.lang.String>>)in theorg.apache.pulsar.client.api.Authentication, and fix call.Documentation
docdoc-requireddoc-not-neededdoc-complete